You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2014/06/05 08:58:01 UTC
[jira] [Commented] (SLING-3501) Unexpected behaviour when using
multiple tags in the web console to run checks
[ https://issues.apache.org/jira/browse/SLING-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018542#comment-14018542 ]
Bertrand Delacretaz commented on SLING-3501:
--------------------------------------------
I agree that OR might be more appropriate in some situations, but it depends on how your HC tag space is structured.
IIUC your patch removes the AND variant, do you see a way to provide both AND or OR? Ideally without breaking compatibility, so maybe something like
tag1,tag2 -> tag1 AND tag2 as now
tag1 OR tag2 -> obvious
tag1 AND tag2 -> obvious
We don't need to support any more complex combinations than this IMO, but both OR and AND make sense.
> Unexpected behaviour when using multiple tags in the web console to run checks
> ------------------------------------------------------------------------------
>
> Key: SLING-3501
> URL: https://issues.apache.org/jira/browse/SLING-3501
> Project: Sling
> Issue Type: Bug
> Components: Health Check
> Reporter: Georg Henzler
> Assignee: Bertrand Delacretaz
> Attachments: SLING-3501-filter-for-taglist-fix.patch
>
>
> Multiple tags (e.g. "category1,category2") are connected with a logical AND at the moment, that means for the given example only HCs with both category tags would be run.
> From a user's point of view this behaviour is not intuitive (IMHO, also see Björn's comment in the sling-users list [1]). Using the tags "category1,category2" should rather cause all checks of both categories to be run (union instead of intersection).
> The problem is evident for both the web console [2] and when configuring CompositeHealthChecks (both use HealthCheckFilter).
> [1] http://apache-sling.73963.n3.nabble.com/Healthcheck-Unexpected-behavior-with-tags-td4032090.html
> [2] http://localhost:4502/system/console/healthcheck
--
This message was sent by Atlassian JIRA
(v6.2#6252)