[GitHub] [activemq] jbonofre commented on a diff in pull request #908: [AMQ-9107] Remove consumers more efficiently in ManagedRegionBroker

[GitBox <gi...@apache.org>]

jbonofre commented on code in PR #908:
URL: https://github.com/apache/activemq/pull/908#discussion_r994700232


##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagedRegionBroker.java:
##########
@@ -215,6 +217,7 @@ public ObjectName registerSubscription(ConnectionContext context, Subscription s
                 registerSubscription(objectName, sub.getConsumerInfo(), key, view);
             }
             subscriptionMap.put(sub, objectName);
+            consumerSubscriptionMap.put(sub.getConsumerInfo(), sub);

Review Comment:
   Good catch, that's possible. At least we should test if `sub` is not null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org