You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2013/05/28 13:15:22 UTC
[jira] [Commented] (LUCENE-5020) Make DrillSidewaysResult ctor
public
[ https://issues.apache.org/jira/browse/LUCENE-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668240#comment-13668240 ]
Michael McCandless commented on LUCENE-5020:
--------------------------------------------
+1, looks great!
> Make DrillSidewaysResult ctor public
> ------------------------------------
>
> Key: LUCENE-5020
> URL: https://issues.apache.org/jira/browse/LUCENE-5020
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-5020.patch
>
>
> DrillSidewaysResult has a package-private ctor which prevents initializing it by an app. I found that it's sometimes useful for e.g. doing some post-processing on the returned TopDocs or List<FacetResult>. Since you cannot return two values from a method, it will be convenient if method could return a new 'processed' DSR.
> I would also like to make the hits member final.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org