[GitHub] [maven] mthmulders commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

[GitBox <gi...@apache.org>]

mthmulders commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r386295152
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/project/ReactorModelPool.java
 ##########
 @@ -19,53 +19,120 @@
  * under the License.
  */
 
-import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Collections;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Map;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.Set;
+
+import org.apache.maven.model.Model;
 
 /**
- * Holds all POM files that are known to the reactor. This allows the project builder to resolve imported POMs from the
+ * Holds all Models that are known to the reactor. This allows the project builder to resolve imported Models from the
  * reactor when building another project's effective model.
  *
  * @author Benjamin Bentmann
+ * @Robert Scholte
 
 Review comment:
   Nitpicking: it should be `@author Robert Scholte`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services