[GitHub] [spark] cloud-fan commented on a change in pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32290:
URL: https://github.com/apache/spark/pull/32290#discussion_r618164295



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -506,6 +506,18 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
       checkKeywordsExistsInExplain(df2, keywords = "[key1=value1, KEY2=VALUE2]")
     }
   }
+
+  test("SPARK-35183: CombineConcats should call transformAllExpressions") {

Review comment:
       It's a bit weird to check the plan using explain result. If we want to have an end-to-end test for this optimization, let's check `sql(...).queryExecution.optimizedPlan` directly.
   
   Normally we only write UT to test optimizer changes, so I'm fine to not have an end-to-end test here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org