You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/16 07:19:49 UTC
[kudu-CR] Enable replay cache by default
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4002
to review the following change.
Change subject: Enable replay cache by default
......................................................................
Enable replay cache by default
We've done looping of the stress tests, as well as some significant
cluster testing (YCSB on 72 node cluster for several days). In the
cluster, we didn't see any significant increased memory usage due to
this feature, nor any stability issues.
Additionally, the risk of the feature is relatively low: the worst
it could cause is memory leaks or crashes, but no chance for permanent
data corruption or loss. For the time being, I am leaving the ability
to disable the feature via a gflag, in case we do see any instability.
We can remove the flag entirely in the 1.0 timeframe.
Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/tserver/tablet_server-test-base.h
7 files changed, 4 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/4002/1
--
To view, visit http://gerrit.cloudera.org:8080/4002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Enable replay cache by default
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Enable replay cache by default
......................................................................
Enable replay cache by default
We've done looping of the stress tests, as well as some significant
cluster testing (YCSB on 72 node cluster for several days). In the
cluster, we didn't see any significant increased memory usage due to
this feature, nor any stability issues.
Additionally, the risk of the feature is relatively low: the worst
it could cause is memory leaks or crashes, but no chance for permanent
data corruption or loss. For the time being, I am leaving the ability
to disable the feature via a gflag, in case we do see any instability.
We can remove the flag entirely in the 1.0 timeframe.
Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
Reviewed-on: http://gerrit.cloudera.org:8080/4002
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/tserver/tablet_server-test-base.h
7 files changed, 4 insertions(+), 19 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Enable replay cache by default
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Enable replay cache by default
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2946/
--
To view, visit http://gerrit.cloudera.org:8080/4002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Enable replay cache by default
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Enable replay cache by default
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35b5e74ac30aa3309a0a7e035c8dff7f61c3f275
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No