[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #31520:
URL: https://github.com/apache/spark/pull/31520#discussion_r571918707



##########
File path: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriterUtils.scala
##########
@@ -106,6 +110,18 @@ object SparkHadoopWriterUtils {
     }
   }
 
+  def commitJob(
+      job: JobContext,
+      uuid: String,
+      committer: FileCommitProtocol,
+      commitMsgs: Seq[TaskCommitMessage]): Long = {

Review comment:
       > The retrun value of `commitJob` seems not be used.
   
   Will be used in https://github.com/apache/spark/pull/31522, revert this in current pr




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org