You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/31 06:22:49 UTC

[kudu-CR] external mini cluster: bump start process timeout a bit more 

Hello Will Berkeley,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13484

to review the following change.


Change subject: external_mini_cluster: bump start process timeout a bit more
......................................................................

external_mini_cluster: bump start process timeout a bit more

Commit 08b916d4b did help reduce the occurrence of NTP desynchronization in
tests, but not completely. Worse, tests that now do time out do so in a way that
doesn't blame NTP at all. For example:

  Bad status: Timed out: failed to start masters: Unable to start Master
  at index 0: Timed out after 60.000s waiting for process (...) to write
  info file (...)

This also affects test result reporting, which tries to avoid reporting test
runs where NTP failed to synchronize by searching for the "Clock considered
unsynchronized" magic string. Of course, that won't happen if the minicluster,
thinking that its subprocesses timed out, kills them before they fail that way.

Here's a dumb fix: let's increase the start process timeout a bit. That gives
the servers more time with which to reach the NTP desynchronization timeout.

Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13484/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] external mini cluster: bump start process timeout a bit more

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13484 )

Change subject: external_mini_cluster: bump start process timeout a bit more
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:25:53 +0000
Gerrit-HasComments: No

[kudu-CR] external mini cluster: bump start process timeout a bit more

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13484 )

Change subject: external_mini_cluster: bump start process timeout a bit more
......................................................................

external_mini_cluster: bump start process timeout a bit more

Commit 08b916d4b did help reduce the occurrence of NTP desynchronization in
tests, but not completely. Worse, tests that now do time out do so in a way that
doesn't blame NTP at all. For example:

  Bad status: Timed out: failed to start masters: Unable to start Master
  at index 0: Timed out after 60.000s waiting for process (...) to write
  info file (...)

This also affects test result reporting, which tries to avoid reporting test
runs where NTP failed to synchronize by searching for the "Clock considered
unsynchronized" magic string. Of course, that won't happen if the minicluster,
thinking that its subprocesses timed out, kills them before they fail that way.

Here's a dumb fix: let's increase the start process timeout a bit. That gives
the servers more time with which to reach the NTP desynchronization timeout.

Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
Reviewed-on: http://gerrit.cloudera.org:8080/13484
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>