You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 00:37:41 UTC
[GitHub] [airflow] jbampton opened a new pull request #13170: Sort and remove duplicates from the spelling wordlist
jbampton opened a new pull request #13170:
URL: https://github.com/apache/airflow/pull/13170
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-753472324
[The Workflow run](https://github.com/apache/airflow/actions/runs/457686142) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-748457041
[The Workflow run](https://github.com/apache/airflow/actions/runs/432281740) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13170:
URL: https://github.com/apache/airflow/pull/13170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-787478565
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-749196512
Static checks fails, can you take a look please @jbampton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-748460644
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-753472385
[The Workflow run](https://github.com/apache/airflow/actions/runs/457651088) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-787209740
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#discussion_r584321535
##########
File path: scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.sh
##########
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# shellcheck source=scripts/ci/libraries/_script_init.sh
+. "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+
+SPELLING_WORDLIST="${AIRFLOW_SOURCES}/docs/spelling_wordlist.txt"
+readonly SPELLING_WORDLIST
+
+export LC_ALL=C
Review comment:
Oh yeah. That one is crucial to get consistency :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-748398257
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13170: Add pre-commit check to sort and remove duplicates from the spelling wordlist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13170:
URL: https://github.com/apache/airflow/pull/13170#issuecomment-748954072
[The Workflow run](https://github.com/apache/airflow/actions/runs/435652178) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org