You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/26 18:36:38 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7438: socket: Remove the unused nx_xxx functions
xiaoxiang781216 opened a new pull request, #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438
## Summary
- net: Remove the unused nx_send to prefer psock_send for kernel
- net: Remove the unused nx_recv[from] to prefer psock_recv[from] for kernel
## Impact
Code refactor only
## Testing
Internal test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7438: socket: Remove the unused nx_xxx functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438#issuecomment-1292490509
> @xiaoxiang781216 removing _NX_SEND() will not make the API unsymmetrical since it still haveing _NX_RECV() ? Why not to create a new macro for _NX_SEND() ?
@acassis the second patch remove _NX_RECV/_NX_RECVFROM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7438: socket: Remove the unused nx_xxx functions
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438#issuecomment-1292488261
@xiaoxiang781216 removing _NX_SEND() will not make the API unsymmetrical since it still haveing _NX_RECV() ? Why not to create a new macro for _NX_SEND() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7438: socket: Remove the unused nx_xxx functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7438: socket: Remove the unused nx_xxx functions
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438#issuecomment-1292505909
> > @xiaoxiang781216 removing _NX_SEND() will not make the API unsymmetrical since it still haveing _NX_RECV() ? Why not to create a new macro for _NX_SEND() ?
>
> @acassis the second patch remove _NX_RECV/_NX_RECVFROM.
Oh sorry, I missed the second commit in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7438: socket: Remove the unused nx_xxx functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7438:
URL: https://github.com/apache/incubator-nuttx/pull/7438#issuecomment-1293551938
@acassis could you merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org