You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 03:29:58 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method

github-actions[bot] commented on code in PR #15889:
URL: https://github.com/apache/doris/pull/15889#discussion_r1068888343


##########
be/test/olap/remote_rowset_gc_test.cpp:
##########
@@ -52,7 +52,7 @@ class RemoteRowsetGcTest : public testing::Test {
         s3_conf.region = config::test_s3_region;

Review Comment:
   warning: no member named 'test_s3_region' in namespace 'doris::config' [clang-diagnostic-error]
   ```cpp
           s3_conf.region = config::test_s3_region;
                                    ^
   ```
   



##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -51,7 +51,7 @@
         s3_conf.region = config::test_s3_region;
         s3_conf.bucket = config::test_s3_bucket;

Review Comment:
   warning: no member named 'test_s3_bucket' in namespace 'doris::config' [clang-diagnostic-error]
   ```cpp
           s3_conf.bucket = config::test_s3_bucket;
                                    ^
   ```
   



##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -51,7 +51,7 @@ class TabletCooldownTest : public testing::Test {
         s3_conf.region = config::test_s3_region;

Review Comment:
   warning: no member named 'test_s3_region' in namespace 'doris::config' [clang-diagnostic-error]
   ```cpp
           s3_conf.region = config::test_s3_region;
                                    ^
   ```
   



##########
be/test/olap/remote_rowset_gc_test.cpp:
##########
@@ -52,7 +52,7 @@
         s3_conf.region = config::test_s3_region;
         s3_conf.bucket = config::test_s3_bucket;

Review Comment:
   warning: no member named 'test_s3_bucket' in namespace 'doris::config' [clang-diagnostic-error]
   ```cpp
           s3_conf.bucket = config::test_s3_bucket;
                                    ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org