[GitHub] [druid] AlexanderSaydakov commented on a change in pull request #12224: latest datasketches-java-3.1.0

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on a change in pull request #12224:
URL: https://github.com/apache/druid/pull/12224#discussion_r817264530



##########
File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildBufferAggregatorHelper.java
##########
@@ -123,7 +126,8 @@ public int getLgK()
 
   private WritableMemory getMemory(final ByteBuffer buf)
   {
-    return memCache.computeIfAbsent(buf, b -> WritableMemory.writableWrap(b, ByteOrder.LITTLE_ENDIAN));
+    return memCache.computeIfAbsent(buf,
+        b -> WritableMemory.writableWrap(b, ByteOrder.LITTLE_ENDIAN, MEM_REQ_SERVER));

Review comment:
       This is to restore support for quantile and HLL4 sketches to be able to grow larger than a given buffer in a buffer aggregator and move to heap in rare cases. This used to be a default before. The problem with this support arose because datasketches-memory was substantially redesigned some time ago, and the default behavior was removed. At that time we should have changed this Druid extension accordingly, but we did not. And because this support is needed in rare circumstances, the problem was not noticed for quite a while.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org