You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "jungm (via GitHub)" <gi...@apache.org> on 2024/11/09 19:53:26 UTC
[PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
jungm opened a new pull request, #1600:
URL: https://github.com/apache/tomee/pull/1600
See https://issues.apache.org/jira/browse/TOMEE-4424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2482320688
Looks like the same tests are failing on main now too (see [full build](https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/master-build-full/lastCompletedBuild/testReport/) and [tck](https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/master-build-full-tck/lastCompletedBuild/testReport/)), I suspect that a change in CXF is causing these failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2483992739
So let's see how it goes https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/153/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2484802543
the 2 failing tests are unrelated, see https://github.com/apache/tomee/commit/9a68d9f8f775be4996a2006abe31de2cb3e02f8c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2466657668
I triggered a rebuild (but the failing tests might be actual regression, so just to be sure). Can you do a JAX-RS TCK run as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2467384957
Ran the JAX-RS TCK now:
```
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] JAXRSClientIT.getMediaTypeTest:129->ReaderClient.invoke:84 » Fault jakarta.ws.rs.client.ResponseProcessingException: Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR] JAXRSClientIT.getMediaTypeTest:149->WriterClient.invoke:57 » Fault ee.jakarta.tck.ws.rs.common.JAXRSCommonClient$Fault: [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.getMediaTypeTest:180->ReaderClient.invoke:50->ReaderClient.invoke:64 » Fault ee.jakarta.tck.ws.rs.common.JAXRSCommonClient$Fault: [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.getMediaTypeTest:140->WriterClient.invoke:39->JaxrsCommonClient.invoke:209 » ResponseProcessing Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR] JAXRSClientIT.invocationFromLinkApplicationJsonMediaTypeTest:154->checkResposeForMessage:194 » ResponseProcessing Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR] JAXRSClientIT.byteArrayProviderTest:172->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.dataSourceProviderTest:260->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.fileProviderTest:243->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.inputStreamProviderTest:206->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.readerProviderTest:226->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.streamingOutputProviderTest:295->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[ERROR] JAXRSClientIT.stringProviderTest:189->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure.
[INFO]
[ERROR] Tests run: 2785, Failures: 0, Errors: 12, Skipped: 132
```
This did definitely break something, I'll look at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #1600:
URL: https://github.com/apache/tomee/pull/1600#discussion_r1835511387
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/servlets/welcomefile/MyRestApi.java:
##########
@@ -0,0 +1,14 @@
+package org.apache.openejb.arquillian.tests.jaxrs.servlets.welcomefile;
Review Comment:
Header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/servlets/welcomefile/ServletsWithWelcomeFileTest.java:
##########
@@ -0,0 +1,56 @@
+package org.apache.openejb.arquillian.tests.jaxrs.servlets.welcomefile;
Review Comment:
Header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/servlets/welcomefile/MyFiletypeServlet.java:
##########
@@ -0,0 +1,15 @@
+package org.apache.openejb.arquillian.tests.jaxrs.servlets.welcomefile;
Review Comment:
Header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/servlets/welcomefile/MyRestApplication.java:
##########
@@ -0,0 +1,6 @@
+package org.apache.openejb.arquillian.tests.jaxrs.servlets.welcomefile;
Review Comment:
Header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1600:
URL: https://github.com/apache/tomee/pull/1600#issuecomment-2482341311
Let's see if the adaptions in https://github.com/apache/tomee/tree/cxf-4.1.x-jsonp-fixes will fix the TCK/build on the manual full build, so we get it sorted out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #1600:
URL: https://github.com/apache/tomee/pull/1600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org