You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "asaf400 (via GitHub)" <gi...@apache.org> on 2024/05/01 13:41:57 UTC

[PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

asaf400 opened a new pull request, #28308:
URL: https://github.com/apache/superset/pull/28308

   ### SUMMARY
    Allow chart operators to exclude the creation of the secret manifest,
    This would effectively support externally created secret - specifically for the template [secret-env.yaml](https://github.com/apache/superset/blob/master/helm/superset/templates/secret-env.yaml)
   
   From externally created sources such as [sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) or [external-secrets](https://github.com/external-secrets/external-secrets) and others..
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28308:
URL: https://github.com/apache/superset/pull/28308#issuecomment-2502460124

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28308?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 60.49%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`98fb6b6`)](https://app.codecov.io/gh/apache/superset/commit/98fb6b64a24d6751d9e005f6db15b40e86b8bf34?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 1094 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #28308   +/-   ##
   =======================================
     Coverage   60.48%   60.49%           
   =======================================
     Files        1931     1931           
     Lines       76236    76238    +2     
     Branches     8568     8566    -2     
   =======================================
   + Hits        46114    46119    +5     
   + Misses      28017    28015    -2     
   + Partials     2105     2104    -1     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/28308?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #28308:
URL: https://github.com/apache/superset/pull/28308#discussion_r1587774246


##########
helm/superset/templates/secret-env.yaml:
##########
@@ -51,3 +51,4 @@ stringData:
     {{ $key }}: {{ $value | quote }}
     {{- end }}
     {{- end }}
+{{- end }}

Review Comment:
   missing an EOL here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "asaf400 (via GitHub)" <gi...@apache.org>.
asaf400 commented on PR #28308:
URL: https://github.com/apache/superset/pull/28308#issuecomment-2088640624

   > Looks good! You'll need to re-gen the chart readme and bump the chart version
   
   Sure, will do, also verify, I'm suspicious of how helm would deal with the declaimer header, then the if,
   Usually the `if` would be the top level 'item'.
   
   I'll test that as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "asaf400 (via GitHub)" <gi...@apache.org>.
asaf400 commented on code in PR #28308:
URL: https://github.com/apache/superset/pull/28308#discussion_r1588159073


##########
helm/superset/templates/secret-env.yaml:
##########
@@ -51,3 +51,4 @@ stringData:
     {{ $key }}: {{ $value | quote }}
     {{- end }}
     {{- end }}
+{{- end }}

Review Comment:
   Added it back 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #28308:
URL: https://github.com/apache/superset/pull/28308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "asaf400 (via GitHub)" <gi...@apache.org>.
asaf400 commented on PR #28308:
URL: https://github.com/apache/superset/pull/28308#issuecomment-2088660364

   seems legit 👍 
   
   Locally against my PR branch with default values (explicit default for new parameter)
   ```
   [root@LAPTOP-ASAF-T14 superset]# helm template . --set secretEnv.create=true -s templates/secret-env.yaml --debug
   install.go:218: [debug] Original chart version: ""
   install.go:235: [debug] CHART PATH: /opt/gits/superset/helm/superset
   
   ---
   # Source: superset/templates/secret-env.yaml
   apiVersion: v1
   kind: Secret
   metadata:
     name: release-name-superset-env
     namespace: default
     labels:
       app: release-name-superset
       chart: superset-0.12.9
       release: "release-name"
       heritage: "Helm"
   type: Opaque
   stringData:
       REDIS_HOST: "release-name-redis-headless"
       REDIS_USER: ""
       REDIS_PORT: "6379"
       REDIS_PROTO: "redis"
       REDIS_DB: "1"
       REDIS_CELERY_DB: "0"
       DB_HOST: "release-name-postgresql"
       DB_PORT: "5432"
       DB_USER: "superset"
       DB_PASS: "superset"
       DB_NAME: "superset"
    ```
    
   And now with the new parameter as false:
   ```
   [root@LAPTOP-ASAF-T14 superset]# helm template . --set secretEnv.create=false -s templates/secret-env.yaml --debug
   install.go:218: [debug] Original chart version: ""
   install.go:235: [debug] CHART PATH: /opt/gits/superset/helm/superset
   
   Error: could not find template templates/secret-env.yaml in chart
   helm.go:84: [debug] could not find template templates/secret-env.yaml in chart
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "asaf400 (via GitHub)" <gi...@apache.org>.
asaf400 commented on PR #28308:
URL: https://github.com/apache/superset/pull/28308#issuecomment-2088723474

   Done, bumped & generated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] refactor(helm): Allow chart operators to exclude the creation of the secret manifest [superset]

Posted by "asaf400 (via GitHub)" <gi...@apache.org>.
asaf400 commented on PR #28308:
URL: https://github.com/apache/superset/pull/28308#issuecomment-2095773859

   Just for future reference and search indexing,
   For those using ArgoCD with the old versions of superset's helm chart and wish to use external secrets,
   I have had limited success with `ignoreDifferences`:
   ```
   apiVersion: argoproj.io/v1alpha1
   kind: Application
   metadata:
     name: superset
     namespace: argocd
   spec:
     ignoreDifferences:
       - kind: "Secret"
         group: "v1"
         jsonPointers:
           - /stringData/DB_HOST
           - /stringData/DB_NAME
           - /stringData/DB_PORT
           - /stringData/DB_PASS
           - /stringData/DB_USER
           - /stringData/REDIS_HOST
           - /stringData/
           - /data/DB_HOST
           - /data/DB_NAME
           - /data/DB_PORT
           - /data/DB_PASS
           - /data/DB_USER
           - /data/REDIS_HOST
           - /data
     project: default
     source:
       chart: superset
       repoURL: https://apache.github.io/superset
       targetRevision: 0.10.0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org