You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "versha890 (via GitHub)" <gi...@apache.org> on 2025/12/16 18:16:02 UTC

[PR] Fix OpenGraph modified_time to use .Params.lastmod [airflow-site]

versha890 opened a new pull request, #1329:
URL: https://github.com/apache/airflow-site/pull/1329

   
   This PR fixes the issue with the OpenGraph `article:modified_time` meta tag.  
   Previously, regenerating the site updated the modification time incorrectly for all posts.  
   Now, it uses `.Params.lastmod` to reflect the actual last modified date set in the post front matter.
   
   ##Changes
   - Updated `_partials/opengraph.html`:
     ```go
     {{ with .Params.lastmod }}
       <meta property="article:modified_time" content="{{ . | time.Format "2006-01-02T15:04:05Z07:00" }}" />
     {{ end }}
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix OpenGraph modified_time to use .Params.lastmod [airflow-site]

Posted by "versha890 (via GitHub)" <gi...@apache.org>.
versha890 commented on PR #1329:
URL: https://github.com/apache/airflow-site/pull/1329#issuecomment-3664641609

   There are some unnecessary changes in this PR.
   It looks like changes from another PR were accidentally mixed in.
   I have separated and fixed this from my side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix OpenGraph modified_time to use .Params.lastmod [airflow-site]

Posted by "versha890 (via GitHub)" <gi...@apache.org>.
versha890 commented on PR #1329:
URL: https://github.com/apache/airflow-site/pull/1329#issuecomment-3664004671

   Thanks for pointing this out.
   I agree that some unrelated changes were accidentally included.
   I’ll separate them and update the PR to contain only the OpenGraph article:modified_time fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix OpenGraph modified_time to use .Params.lastmod [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1329:
URL: https://github.com/apache/airflow-site/pull/1329#issuecomment-3663233150

   There are some unnecessary changes
   I think changes from another PR are mixed in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix OpenGraph modified_time to use .Params.lastmod [airflow-site]

Posted by "versha890 (via GitHub)" <gi...@apache.org>.
versha890 closed pull request #1329: Fix OpenGraph modified_time to use .Params.lastmod
URL: https://github.com/apache/airflow-site/pull/1329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org