You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/14 08:08:27 UTC

Re: Review Request 12766: Reverted metering from Statistics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12766/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 7:08 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
-------

Rebase.


Repository: mesos-git


Description
-------

There are no longer any uses of the meters, so in anticipation for cleaning up Statistics, I'd like to remove them to simplify the code.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/statistics.hpp ce122a5eaa1aa9c09207cc8c9428136b681561cf 
  3rdparty/libprocess/src/statistics.cpp d4ba9f146f7b9b46525a0e27fbfb3d61a21a94fc 
  3rdparty/libprocess/src/tests/statistics_tests.cpp e6c9a1b776d6f3339f96898c3501d2a00c416006 

Diff: https://reviews.apache.org/r/12766/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 12766: Reverted metering from Statistics.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12766/#review31833
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 14, 2014, 7:08 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12766/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 7:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There are no longer any uses of the meters, so in anticipation for cleaning up Statistics, I'd like to remove them to simplify the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/statistics.hpp ce122a5eaa1aa9c09207cc8c9428136b681561cf 
>   3rdparty/libprocess/src/statistics.cpp d4ba9f146f7b9b46525a0e27fbfb3d61a21a94fc 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp e6c9a1b776d6f3339f96898c3501d2a00c416006 
> 
> Diff: https://reviews.apache.org/r/12766/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>