You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/28 08:26:32 UTC

[GitHub] [dubbo-go] mosandao opened a new pull request #812: Fix: Nacos remoting and config_center

mosandao opened a new pull request #812:
URL: https://github.com/apache/dubbo-go/pull/812


   What this PR does:
   修改 nacos 无法注册指定命名空间
   修改 nacos 无法获取指定命名空间配置文件
   
   Special notes for your reviewer:
   修改了三处代码
   
   common/constant/key.go
   config_center/nacos/client.go
   remoting/nacos/builder.go
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] mosandao commented on pull request #812: Fix: Nacos remoting and config_center

Posted by GitBox <gi...@apache.org>.
mosandao commented on pull request #812:
URL: https://github.com/apache/dubbo-go/pull/812#issuecomment-717884156


   没有进行代码格式化


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] mosandao closed pull request #812: Fix: Nacos remoting and config_center

Posted by GitBox <gi...@apache.org>.
mosandao closed pull request #812:
URL: https://github.com/apache/dubbo-go/pull/812


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] mosandao commented on a change in pull request #812: Fix: Nacos remoting and config_center

Posted by GitBox <gi...@apache.org>.
mosandao commented on a change in pull request #812:
URL: https://github.com/apache/dubbo-go/pull/812#discussion_r513383563



##########
File path: common/constant/key.go
##########
@@ -166,7 +166,7 @@ const (
 	NACOS_CATEGORY_KEY           = "category"
 	NACOS_PROTOCOL_KEY           = "protocol"
 	NACOS_PATH_KEY               = "path"
-	NACOS_NAMESPACE_ID           = "namespaceId"
+	NACOS_NAMESPACE_KEY           = "namespace"

Review comment:
       嗯嗯好的




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] watermelo commented on a change in pull request #812: Fix: Nacos remoting and config_center

Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #812:
URL: https://github.com/apache/dubbo-go/pull/812#discussion_r513334506



##########
File path: common/constant/key.go
##########
@@ -166,7 +166,7 @@ const (
 	NACOS_CATEGORY_KEY           = "category"
 	NACOS_PROTOCOL_KEY           = "protocol"
 	NACOS_PATH_KEY               = "path"
-	NACOS_NAMESPACE_ID           = "namespaceId"
+	NACOS_NAMESPACE_KEY           = "namespace"

Review comment:
       fmt the codes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org