You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/24 01:44:08 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

masayuki2009 opened a new pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159


   ## Summary
   
   - This commit removes critical section in mm_sem.c which was
     added to stabilize the NuttX SMP kernel in Mar 2018.
   
   ## Impact
   
   - SMP only
   
   ## Testing
   
   - Tested with ostest with the following configs
     - maix-bit:smp (QEMU), esp32-devkitc:smp (QEMU)
     - sabre-6quad:smp (QEMU), spresense:smp, sim:smp
   - Tested with nxplayer with the following configs
     - spresense:wifi_smp, spresense:rndis_smp
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159#issuecomment-805525790


   > I noticed that nxplayer with spresense:rndis_smp stopped after 5.3hrs.
   > Let me check if the issue relates to this PR.
   
   Sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159#issuecomment-811597103


   @xiaoxiang781216 
   
   Please merge this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159#issuecomment-810749271


   >I noticed that nxplayer with spresense:rndis_smp stopped after 5.3hrs.
   >Let me check if the issue relates to this PR.
   
   Finally, I found the root cause of the issue. 
   I will test this PR again once #3254 is merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3159: mm: mm_heap: Remove critical section in mm_sem.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3159:
URL: https://github.com/apache/incubator-nuttx/pull/3159#issuecomment-805475519


   I noticed that nxplayer with spresense:rndis_smp stopped after 5.3hrs.
   Let me check if the issue relates to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org