[GitHub] [incubator-doris] Dam1029 commented on a change in pull request #5112: [Enhancement] Add more comprehensive prometheus jvm thread metrics on fe

[GitBox <gi...@apache.org>]

Dam1029 commented on a change in pull request #5112:
URL: https://github.com/apache/incubator-doris/pull/5112#discussion_r548361566



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/proc/JvmProcDir.java
##########
@@ -94,6 +94,12 @@ public ProcResult fetchResult() throws AnalysisException {
         Threads threads = jvmStats.getThreads();
         result.addRow(genRow("threads count", threads.getCount()));
         result.addRow(genRow("threads peak count", threads.getPeakCount()));
+        result.addRow(genRow("threads new count", threads.getThreadsNewCount()));

Review comment:
       Jvm Thread State is enum type. A thread can be in one of the following states: NEW,RUNNABLE,BLOCKED,WAITING,TIMED_WAITING,TIMED_WAITING,TERMINATED. 
   A fe thread can be in only one state at a given point in time. The new metrics mean how many fe threads in a specific state. I think this will be useful when we want to analysis fe whole running status.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org