You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/07 10:35:11 UTC
[GitHub] [submarine] ByronHsu opened a new pull request #581: SUBMARINE-817. Add model management e2e test
ByronHsu opened a new pull request #581:
URL: https://github.com/apache/submarine/pull/581
### What is this PR for?
1. Forward mlflow and minio port for testing.
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? Yes/No
* Are there breaking changes for older versions? Yes/No
* Does this need new documentation? Yes/No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on pull request #581: SUBMARINE-817. Add model management e2e test
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #581:
URL: https://github.com/apache/submarine/pull/581#issuecomment-835368981
> @jeff-901 @kobe860219 Help me review the code. Thanks!
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 merged pull request #581: SUBMARINE-817. Add model management e2e test
Posted by GitBox <gi...@apache.org>.
kobe860219 merged pull request #581:
URL: https://github.com/apache/submarine/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 commented on pull request #581: SUBMARINE-817. Add model management e2e test
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #581:
URL: https://github.com/apache/submarine/pull/581#issuecomment-836228685
LGTM. Thanks @ByronHsu your contribution! Some test is failed, is it need to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on pull request #581: SUBMARINE-817. Add model management e2e test
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #581:
URL: https://github.com/apache/submarine/pull/581#issuecomment-834519513
@jeff-901 @kobe860219 Help me review the code. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on pull request #581: SUBMARINE-817. Add model management e2e test
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #581:
URL: https://github.com/apache/submarine/pull/581#issuecomment-836513829
@kobe860219 No, they have been fixed in https://github.com/apache/submarine/pull/582.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org