You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/02 18:10:44 UTC
[GitHub] [solr] nginthfs commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size
nginthfs commented on code in PR #1205:
URL: https://github.com/apache/solr/pull/1205#discussion_r1038399026
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -336,8 +337,8 @@ public void run() {
for (Pair<String, byte[]> head : queue) {
byte[] data = head.second();
final ZkNodeProps message = ZkNodeProps.load(data);
- if (log.isDebugEnabled()) {
Review Comment:
This was made INFO level because it's helpful for debugging Solr admin issues. It's only one log per operation, so it shouldn't be too verbose, and on our fork in practice it hasn't been an issue. (same goes for the other log made INFO level)
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -336,8 +337,8 @@ public void run() {
for (Pair<String, byte[]> head : queue) {
byte[] data = head.second();
final ZkNodeProps message = ZkNodeProps.load(data);
- if (log.isDebugEnabled()) {
Review Comment:
This was made INFO level because it's helpful for debugging Solr admin issues when they happen in production. It's only one log per operation, so it shouldn't be too verbose, and on our fork in practice it hasn't been an issue. (same goes for the other log made INFO level)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org