review granted: [Bug 123690] CRASH when decreasing color picker vertical size too much : [Attachment 82282] patch to solve the crash

[bu...@apache.org]

Oliver-Rainer Wittmann <or...@apache.org> has granted  review:
Bug 123690: CRASH when decreasing color picker vertical size too much
https://issues.apache.org/ooo/show_bug.cgi?id=123690

Attachment 82282: patch to solve the crash
https://issues.apache.org/ooo/attachment.cgi?id=82282&action=edit


------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
The crash is triggered by method <createBlendFrame(..)> by calling
<BitmapWriteAccess::SetPixel(..)> with inappropriate value for <y>.
Due to the given comments regarding the values of <x> and <y> I identified the
root cause: in case that <nH == 1> given statement <y == nH - 1> is not hold.

@Armin: As you are the author of method 
BitmapEx createBlendFrame( const Size&, sal_uInt8, Color, Color, Color, Color )

I asking you for a review of the proposed patch.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org