[GitHub] [spark] gengliangwang commented on issue #25300: [SPARK-28503][SQL] Return null result on cast an out-of-range value to a integral type

[GitBox <gi...@apache.org>]

gengliangwang commented on issue #25300: [SPARK-28503][SQL] Return null result on cast an out-of-range value to a integral type
URL: https://github.com/apache/spark/pull/25300#issuecomment-516735715
 
 
   > I've left the same comment in #25239 (comment) though, Cast itself needs to support this kind of upcast behaivours? As another option, we could check value ranges by IF expressions: master...maropu:SPARK-28503
   
   @maropu I check the code in master...maropu:SPARK-28503 . It seems clean and simple. Not sure if there is difference in performance. The fixes of this PR is only about casting to byte/short/int/long type, so I think it is also fine with the straightforward solution in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org