You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/10/28 22:57:01 UTC

[GitHub] [thrift] Jens-G commented on a change in pull request #2474: THRIFT-5474: TSimpleJsonProtocol with inner quotes does not produce valid JSON.

Jens-G commented on a change in pull request #2474:
URL: https://github.com/apache/thrift/pull/2474#discussion_r738828325



##########
File path: lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
##########
@@ -314,6 +314,7 @@ public void writeString(String str) throws TException {
       char c = str.charAt(i);
       switch (c) {
       case '"':
+        escape.append('\\');
       case '\\':

Review comment:
       So this is the whole net patch content, buried under a pile of unrelated other changes. 
   Plus I don't think this change is even remotely correct




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org