You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/18 17:41:35 UTC

[GitHub] [tvm] junrushao1994 commented on pull request #9306: [TIR] Add structural error printing for TensorIR

junrushao1994 commented on pull request #9306:
URL: https://github.com/apache/tvm/pull/9306#issuecomment-946007635


   Hey thanks for the PR! It's a pretty nice POC, and I would like to deliberate on the format :-)
   
   - Shall we update the syntax in the description to reflect the latest change on mainline? Also please add a few unittests
   - If the error location is at a particular loop, let's avoid fusing it with other loops with `tir.grid`
   - Also we should consider printing the names of the error locations under the annotations, so that the error message could be clearly referring to these blocks/loops


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org