You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "majinkai (GitHub)" <gi...@apache.org> on 2018/12/18 08:14:47 UTC

[GitHub] [incubator-dubbo] majinkai opened pull request #3004: Add javadoc for dubbo-serialization module(#3002).

## What is the purpose of the change

XXXXX

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi, @majinkai jinkai,
I think maybe more details is better.
For ex, we should tell developer how to use 'SerializationOptimizer'.
Maybe more details will be better.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh closed pull request #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
@ralf0131 Agree with u. I'd like merge this first.
@majinkai We still have some work to improve this. :)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=h1) Report
> Merging [#3004](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e4acdf72f644c0f4f1adad0257615567ef2bb649?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   64.29%   64.27%   -0.02%     
==========================================
  Files         584      584              
  Lines       26055    26055              
  Branches     4561     4561              
==========================================
- Hits        16753    16748       -5     
- Misses       7124     7127       +3     
- Partials     2178     2180       +2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ommon/serialize/fastjson/FastJsonObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZhc3Rqc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2Zhc3Rqc29uL0Zhc3RKc29uT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...n/serialize/protostuff/ProtostuffObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3Rvc3R1ZmYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9zdHVmZi9Qcm90b3N0dWZmT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/common/serialize/fst/FstFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0RmFjdG9yeS5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../dubbo/common/serialize/kryo/KryoObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by9LcnlvT2JqZWN0T3V0cHV0LmphdmE=) | `80.55% <ø> (ø)` | :arrow_up: |
| [...ommon/serialize/hessian2/Hessian2ObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...he/dubbo/common/serialize/fst/FstObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...che/dubbo/common/serialize/fst/FstObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0SW5wdXQuamF2YQ==) | `88.46% <ø> (ø)` | :arrow_up: |
| [...n/serialize/nativejava/NativeJavaObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWpkay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9uYXRpdmVqYXZhL05hdGl2ZUphdmFPYmplY3RPdXRwdXQuamF2YQ==) | `88.88% <ø> (ø)` | :arrow_up: |
| ... and [41 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=footer). Last update [e4acdf7...f9b9241](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=h1) Report
> Merging [#3004](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e4acdf72f644c0f4f1adad0257615567ef2bb649?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##           master   #3004     +/-   ##
========================================
- Coverage   64.29%   64.2%   -0.1%     
========================================
  Files         584     584             
  Lines       26055   26055             
  Branches     4561    4561             
========================================
- Hits        16753   16728     -25     
- Misses       7124    7141     +17     
- Partials     2178    2186      +8
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ommon/serialize/fastjson/FastJsonObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZhc3Rqc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2Zhc3Rqc29uL0Zhc3RKc29uT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...n/serialize/protostuff/ProtostuffObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3Rvc3R1ZmYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9zdHVmZi9Qcm90b3N0dWZmT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/common/serialize/fst/FstFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0RmFjdG9yeS5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../dubbo/common/serialize/kryo/KryoObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by9LcnlvT2JqZWN0T3V0cHV0LmphdmE=) | `80.55% <ø> (ø)` | :arrow_up: |
| [...ommon/serialize/hessian2/Hessian2ObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...he/dubbo/common/serialize/fst/FstObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...che/dubbo/common/serialize/fst/FstObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0SW5wdXQuamF2YQ==) | `88.46% <ø> (ø)` | :arrow_up: |
| [...n/serialize/nativejava/NativeJavaObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWpkay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9uYXRpdmVqYXZhL05hdGl2ZUphdmFPYmplY3RPdXRwdXQuamF2YQ==) | `88.88% <ø> (ø)` | :arrow_up: |
| ... and [32 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=footer). Last update [e4acdf7...ac26e2f](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Maybe we need doc for every param.
:)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=h1) Report
> Merging [#3004](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e4acdf72f644c0f4f1adad0257615567ef2bb649?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   64.29%   64.24%   -0.06%     
==========================================
  Files         584      584              
  Lines       26055    26055              
  Branches     4561     4561              
==========================================
- Hits        16753    16738      -15     
- Misses       7124     7135      +11     
- Partials     2178     2182       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ommon/serialize/fastjson/FastJsonObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZhc3Rqc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2Zhc3Rqc29uL0Zhc3RKc29uT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...n/serialize/protostuff/ProtostuffObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3Rvc3R1ZmYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9zdHVmZi9Qcm90b3N0dWZmT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/common/serialize/fst/FstFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0RmFjdG9yeS5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../dubbo/common/serialize/kryo/KryoObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by9LcnlvT2JqZWN0T3V0cHV0LmphdmE=) | `80.55% <ø> (ø)` | :arrow_up: |
| [...ommon/serialize/hessian2/Hessian2ObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...he/dubbo/common/serialize/fst/FstObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0T3V0cHV0LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...che/dubbo/common/serialize/fst/FstObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0T2JqZWN0SW5wdXQuamF2YQ==) | `88.46% <ø> (ø)` | :arrow_up: |
| [...n/serialize/nativejava/NativeJavaObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWpkay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9uYXRpdmVqYXZhL05hdGl2ZUphdmFPYmplY3RPdXRwdXQuamF2YQ==) | `88.88% <ø> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3004/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=footer). Last update [e4acdf7...ac26e2f](https://codecov.io/gh/apache/incubator-dubbo/pull/3004?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] majinkai commented on pull request #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "majinkai (GitHub)" <gi...@apache.org>.
It is my mistake

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3004: Add javadoc for dubbo-serialization module(#3002).

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
:)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3004 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org