You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Nick Dimiduk (Jira)" <ji...@apache.org> on 2022/04/13 19:59:00 UTC

[jira] [Commented] (HBASE-26766) Introduce custom attributes to threads

    [ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521917#comment-17521917 ] 

Nick Dimiduk commented on HBASE-26766:
--------------------------------------

Hi [~sairampola6]. Thanks for the write up and the PR. I was wondering if you could elaborate a bit more on your needs here. Is this a feature you need for implementing some feature in Phoenix? I'm familiar with the pain of associating log lines with a specific user request, it's something I've wanted for a long time as well. However, I think the recent work integrating OpenTelemetry into HBase (HBASE-26419) and Hadoop (HADOOP-15566) is a more wholistic platform upon which to devise a solution to the request-level log use-case. For example, maybe we can add the otel trace_id to the logger's pattern layout and.

Perhaps though you have other features for Phoenix in mind that are not operational in nature, where it would be useful to decorate threads used in the HBase runtime environment that Phoenix leverages for query execution. In that case, it may make sense that HBase should build an explicit API supporting these use-cases. Your proposal doc implies but doesn't say anything about what these other use-cases might be, so as of now, I'm of the opinion that you should instead use OpenTelemetry's Context objects for attribute propagation.

> Introduce custom attributes to threads
> --------------------------------------
>
>                 Key: HBASE-26766
>                 URL: https://issues.apache.org/jira/browse/HBASE-26766
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Pola Sairam
>            Assignee: Pola Sairam
>            Priority: Major
>             Fix For: 1.7.2
>
>
> The idea is to introduce custom attributes to a thread. We will be passing this from thread to newly spawned thread. More details can be found here: https://docs.google.com/document/d/1b6CJt7_E8NU5fe41yeZZhuVPx-5SDx7x1jNtIRmnR_g/edit#heading=h.bv19tq8gxgcv



--
This message was sent by Atlassian Jira
(v8.20.1#820001)