You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org> on 2013/11/14 18:51:28 UTC
[jira] [Resolved] (TRINIDAD-2401) Clean up skinning code to avoid
use of obsolete synchronized classes
[ https://issues.apache.org/jira/browse/TRINIDAD-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan resolved TRINIDAD-2401.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.1.0-core
r1503980 | bsullivan | 2013-07-17 03:00:30 +0000 | 3 lines
Changed paths:
M /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/cache/FileSystemStyleCache.java
M /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java
M /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/NameUtils.java
M /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/StyleWriterFactory.java
M /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java
[Trinidad]TRINIDAD-2401 Clean up skinning code to avoid use of obsolete synchronized classes
The skinning code currently uses several obsolete implementation class--Vector, Stack, HashTable that are implicitly synchronized. None of this synchronization is necessary. Replaces these classes with their modern equivalents. In addition, much of the code is confusing due to functions performing multiple different tasks simultaneously. Break these up into easy to understand pieces that perform a single task.
> Clean up skinning code to avoid use of obsolete synchronized classes
> --------------------------------------------------------------------
>
> Key: TRINIDAD-2401
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2401
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Blake Sullivan
> Assignee: Blake Sullivan
> Priority: Minor
> Fix For: 2.1.0-core
>
> Attachments: jira2401_main.diff
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The skinning code currently uses several obsolete implementation class--Vector, Stack, HashTable that are implicitly synchronized. None of this synchronization is necessary. Replaces these classes with their modern equivalents. In addition, much of the code is confusing due to functions performing multiple different tasks simultaneously. Break these up into easy to understand pieces that perform a single task.
--
This message was sent by Atlassian JIRA
(v6.1#6144)