You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/20 10:58:37 UTC
[GitHub] [airflow] pcandoalmeida opened a new pull request #11032: Add D202 pydocstyle check
pcandoalmeida opened a new pull request #11032:
URL: https://github.com/apache/airflow/pull/11032
Enabled D202 Pydocstyle check
* Fixed all pre-commit errors
Part of issue: #10742
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696673880
OK sure @kaxil 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696036377
Let me know when you are happy to mark the "PR ready for review" -- I think it is but just want to make sure :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696448646
Can you rebase to the master, it should be better now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696052095
Hi @kaxil sorry, I was trying to find out why I was getting a K8s error. I'll see if I get an error with the latest CI run, might need to rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on a change in pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on a change in pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#discussion_r491688049
##########
File path: airflow/providers/amazon/aws/hooks/glue_catalog.py
##########
@@ -104,12 +104,10 @@ def get_table(self, database_name, table_name):
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
-
>>> hook = AwsGlueCatalogHook()
Review comment:
Yep, that works, thanks @mik-laj!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696052095
Hi @kaxil sorry, I was trying to find out why I was getting a K8s error. I'll see if I get an error with the latest CI run, might need to rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11032:
URL: https://github.com/apache/airflow/pull/11032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#discussion_r491686097
##########
File path: airflow/providers/amazon/aws/hooks/glue_catalog.py
##########
@@ -104,12 +104,10 @@ def get_table(self, database_name, table_name):
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
-
>>> hook = AwsGlueCatalogHook()
Review comment:
```
"""
Get the information of the table
.. code-block:: py
hook = AwsGlueCatalogHook()
r = hook.get_table('db', 'table_foo')
r['Name'] = 'table_foo'
:param database_name: Name of hive database (schema) @table belongs to
:type database_name: str
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
"""
```
Can you try it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696052770
Yeah don't worry about the Kubernetes tests, they are unrelated to the PR, looks like some transient error which we will look into.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#discussion_r491686097
##########
File path: airflow/providers/amazon/aws/hooks/glue_catalog.py
##########
@@ -104,12 +104,10 @@ def get_table(self, database_name, table_name):
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
-
>>> hook = AwsGlueCatalogHook()
Review comment:
```
"""
Get the information of the table
.. code-block:: py
hook = AwsGlueCatalogHook()
r = hook.get_table('db', 'table_foo')
r['Name'] = 'table_foo'
:param database_name: Name of hive database (schema) @table belongs to
:type database_name: str
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
"""
```
Can you try it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696036377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on a change in pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on a change in pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#discussion_r491688049
##########
File path: airflow/providers/amazon/aws/hooks/glue_catalog.py
##########
@@ -104,12 +104,10 @@ def get_table(self, database_name, table_name):
:param table_name: Name of hive table
:type table_name: str
:rtype: dict
-
>>> hook = AwsGlueCatalogHook()
Review comment:
Yep, that works, thanks @mik-laj!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pcandoalmeida commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696673880
OK sure @kaxil 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11032:
URL: https://github.com/apache/airflow/pull/11032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11032: Add D202 pydocstyle check
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11032:
URL: https://github.com/apache/airflow/pull/11032#issuecomment-696448646
Can you rebase to the master, it should be better now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org