You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/12/13 07:02:46 UTC
Review Request 16240: CLOUDSTACK-5487: Fixing indentation issues in
test_portable_ip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16240/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar, Rayees Namathponnan, and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5487
https://issues.apache.org/jira/browse/CLOUDSTACK-5487
Repository: cloudstack-git
Description
-------
Fixed indentation issue in test_portable_ip.
The review request at https://reviews.apache.org/r/16115/ can be discarded. The change "virtual_machine" to "virtual_machine2" is not needed as mentioned in review comment.
Diffs
-----
test/integration/component/test_portable_ip.py dda6555
Diff: https://reviews.apache.org/r/16240/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 16240: CLOUDSTACK-5487: Fixing indentation issues in
test_portable_ip
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16240/#review30437
-----------------------------------------------------------
Commit d92e560f653bfb9cd81adc6e1dbccf36f078fa3f in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d92e560 ]
CLOUDSTACK-5487: Fixing indentation issues in Portable IP
- ASF Subversion and Git Services
On Dec. 13, 2013, 6:02 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16240/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Rayees Namathponnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5487
> https://issues.apache.org/jira/browse/CLOUDSTACK-5487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed indentation issue in test_portable_ip.
> The review request at https://reviews.apache.org/r/16115/ can be discarded. The change "virtual_machine" to "virtual_machine2" is not needed as mentioned in review comment.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py dda6555
>
> Diff: https://reviews.apache.org/r/16240/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 16240: CLOUDSTACK-5487: Fixing indentation issues in
test_portable_ip
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16240/#review30438
-----------------------------------------------------------
Ship it!
Committed to 4.3. 4.2 and master did not require this change.
- Girish Shilamkar
On Dec. 13, 2013, 6:02 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16240/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Rayees Namathponnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5487
> https://issues.apache.org/jira/browse/CLOUDSTACK-5487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed indentation issue in test_portable_ip.
> The review request at https://reviews.apache.org/r/16115/ can be discarded. The change "virtual_machine" to "virtual_machine2" is not needed as mentioned in review comment.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py dda6555
>
> Diff: https://reviews.apache.org/r/16240/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>