You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/04/30 15:48:48 UTC

[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #5045: NIFI-8431: remove redundant validation of dynamic properties

ChrisSamo632 commented on a change in pull request #5045:
URL: https://github.com/apache/nifi/pull/5045#discussion_r623982635



##########
File path: nifi-api/src/main/java/org/apache/nifi/components/AbstractConfigurableComponent.java
##########
@@ -126,19 +125,6 @@ private PropertyDescriptor getSupportedPropertyDescriptor(final PropertyDescript
             }
         }
 
-        // validate any dynamic properties
-        for (final Map.Entry<PropertyDescriptor, String> entry : context.getProperties().entrySet()) {
-            final PropertyDescriptor descriptor = entry.getKey();
-            final String value = entry.getValue();
-
-            if (supportedDescriptors != null && !supportedDescriptors.contains(descriptor)) {

Review comment:
       I think the `supportedDescriptors` is no longer needed (line 96)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org