You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/09/19 17:52:28 UTC

[GitHub] [superset] michael-s-molina opened a new pull request, #25343: feat: Adds Sunburst chart migration logic

michael-s-molina opened a new pull request, #25343:
URL: https://github.com/apache/superset/pull/25343

   ### SUMMARY
   This PR adds the Sunburst chart migration logic (D3 ➡️ ECharts). Users can execute this migration using the https://github.com/apache/superset/pull/25304 CLI command and disable the legacy version with the [VIZ_TYPE_DENYLIST](https://github.com/apache/superset/blob/ec6191023263ac5f8292dd37f037805c3196e029/superset/config.py#L829) configuration.
   
   @sadpandajoe @jinghua-qa
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1341" alt="Screenshot 2023-09-19 at 14 47 47" src="https://github.com/apache/superset/assets/70410625/7dbe218d-806f-42f2-8c19-13fd71b8adae">
   <img width="1341" alt="Screenshot 2023-09-19 at 14 48 30" src="https://github.com/apache/superset/assets/70410625/1c9e58fe-95c0-4ca8-881f-338a3d45fc86">
   
   ### TESTING INSTRUCTIONS
   1 - Upgrade a Sunburst chart using the CLI command
   2 - Check the new chart
   3 - Downgrade a Sunburst chart using the CLI command
   4 - Check the legacy chart
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-code-scanning[bot] commented on a diff in pull request #25343: feat: Adds Sunburst chart migration logic

Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #25343:
URL: https://github.com/apache/superset/pull/25343#discussion_r1330512632


##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts:
##########
@@ -138,7 +138,10 @@
       color: ${theme.colors.grayscale.base}"
      >`,
     `<div style="font-weight: ${theme.typography.weights.bold}">
-      ${node.name}
+      ${(node.name || NULL_STRING)
+        .toString()
+        .replace('<', '&lt;')

Review Comment:
   ## Incomplete string escaping or encoding
   
   This replaces only the first occurrence of '<'.
   
   [Show more details](https://github.com/apache/superset/security/code-scanning/1213)



##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts:
##########
@@ -138,7 +138,10 @@
       color: ${theme.colors.grayscale.base}"
      >`,
     `<div style="font-weight: ${theme.typography.weights.bold}">
-      ${node.name}
+      ${(node.name || NULL_STRING)
+        .toString()
+        .replace('<', '&lt;')
+        .replace('>', '&gt;')}

Review Comment:
   ## Incomplete string escaping or encoding
   
   This replaces only the first occurrence of '>'.
   
   [Show more details](https://github.com/apache/superset/security/code-scanning/1212)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina merged pull request #25343: feat: Adds Sunburst chart migration logic

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #25343:
URL: https://github.com/apache/superset/pull/25343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org