You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/07/01 11:41:00 UTC

[jira] [Work logged] (NUMBERS-125) BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary

     [ https://issues.apache.org/jira/browse/NUMBERS-125?focusedWorklogId=270086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270086 ]

ASF GitHub Bot logged work on NUMBERS-125:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/19 11:40
            Start Date: 01/Jul/19 11:40
    Worklog Time Spent: 10m 
      Work Description: Schamschi commented on pull request #61: [NUMBERS-125] Remove redundant methods BigFraction.reduce() and Fraction.getReducedFraction(int, int)
URL: https://github.com/apache/commons-numbers/pull/61
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 270086)
            Time Spent: 10m
    Remaining Estimate: 0h

> BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary
> ------------------------------------------------------------------------------
>
>                 Key: NUMBERS-125
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-125
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: fraction
>    Affects Versions: 1.0
>            Reporter: Heinrich Bohne
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The instance method {{BigFraction.reduce()}} is unnecessary, because the only constructor in this class already reduces the fraction to lowest terms.
> Likewise, the static factory method {{Fraction.getReducedFraction(int, int)}} is unnecessary, because it is functionally completely equivalent to the factory method {{Fraction.of(int, int)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)