You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/09 13:11:17 UTC
[GitHub] [kafka] showuon opened a new pull request #11009: MINOR: update doc for default assignor change
showuon opened a new pull request #11009:
URL: https://github.com/apache/kafka/pull/11009
Update the doc and upgrade doc for default assignor change.
REF: https://github.com/apache/kafka/pull/10903
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11009:
URL: https://github.com/apache/kafka/pull/11009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11009:
URL: https://github.com/apache/kafka/pull/11009#issuecomment-879362003
Seeing as these are just docs changes and at least one build passed completely while others just had a handful of flaky tests fail, I think we can go ahead and merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11009:
URL: https://github.com/apache/kafka/pull/11009#discussion_r668314609
##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##########
@@ -114,15 +114,17 @@
"ordered by preference, of supported partition assignment strategies that the client will use to distribute " +
"partition ownership amongst consumer instances when group management is used. Available options are:" +
"<ul>" +
- "<li><code>org.apache.kafka.clients.consumer.RangeAssignor</code>: The default assignor, which works on a per-topic basis.</li>" +
+ "<li><code>org.apache.kafka.clients.consumer.RangeAssignor</code>: Assigns partitions on a per-topic basis.</li>" +
"<li><code>org.apache.kafka.clients.consumer.RoundRobinAssignor</code>: Assigns partitions to consumers in a round-robin fashion.</li>" +
"<li><code>org.apache.kafka.clients.consumer.StickyAssignor</code>: Guarantees an assignment that is " +
"maximally balanced while preserving as many existing partition assignments as possible.</li>" +
"<li><code>org.apache.kafka.clients.consumer.CooperativeStickyAssignor</code>: Follows the same StickyAssignor " +
"logic, but allows for cooperative rebalancing.</li>" +
"</ul>" +
+ "<p>The default assignor is [RangeAssignor, CooperativeStickyAssignor], which will use RangeAssignor to do assignment, " +
+ "but just needs 1 rolling bounce to upgrade to CooperativeStickyAssignor</p>" +
Review comment:
```suggestion
"<p>The default assignor is [RangeAssignor, CooperativeStickyAssignor], which will use the RangeAssignor by default, " +
"but allows upgrading to the CooperativeStickyAssignor with just a single rolling bounce that removes the RangeAssignor from the list</p>" +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11009:
URL: https://github.com/apache/kafka/pull/11009#issuecomment-877176315
@ableegoldman , I found I forgot to update the doc to reflect the default assignor change. Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11009:
URL: https://github.com/apache/kafka/pull/11009#issuecomment-879367860
Merged to trunk and cherrypicked to 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11009: MINOR: update doc for default assignor change
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11009:
URL: https://github.com/apache/kafka/pull/11009#issuecomment-879049924
Previous build has one test group timeout. Re-trigger it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org