You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/03 18:45:44 UTC
[GitHub] matthiasblaesing commented on issue #877: [NETBEANS-1074] Module
Review servletjspapi + web.jspparser
matthiasblaesing commented on issue #877: [NETBEANS-1074] Module Review servletjspapi + web.jspparser
URL: https://github.com/apache/incubator-netbeans/pull/877#issuecomment-426752675
Looks mostly sane. The build process looks ok - the license verification is not yet happy:
- generated-servlet3.1-jsp2.3-api-license.txt is missing "Version" and "Type: generated" headers
- There are license files with trailing spaces (behind the "Oracle"):
enterprise/web.jspparser/external/common-util-5.0-license.txt has a trailing space on line #5
enterprise/web.jspparser/external/glassfish-ee-api-4.1-license.txt has a trailing space on line #5
enterprise/web.jspparser/external/javax.el-2.2.6-license.txt has a trailing space on line #5
enterprise/web.jspparser/external/javax.servlet.jsp-2.3.2-license.txt has a trailing space on line #5
enterprise/servletjspapi/external/el-api-2.2-license.txt has a trailing space on line #5
enterprise/servletjspapi/external/javax.servlet.jsp-api-2.3.3-license.txt has a trailing space on line #5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists