You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/01 00:16:26 UTC

[GitHub] [arrow] seddonm1 commented on pull request #9567: ARROW-11775: [Rust][DataFusion] Feature Flags for Dependencies

seddonm1 commented on pull request #9567:
URL: https://github.com/apache/arrow/pull/9567#issuecomment-787554082


   Thanks @alamb and @elferherrera 
   
   I have incorporated both your ideas within the limitations of the rust compiler; namely:
   1. feature flag names if used like `#[cfg(feature = "crypto_expressions")]` lose type safety on the feature name so care needs to be taken.
   2. using the `cfg!` macro looks like it would work but requires the function to compile under both conditions which is not easy. 
   
   I have also updated the rust.yml CICD file and added tests for consistency.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org