You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:58:42 UTC
[GitHub] [incubator-inlong] doleyzi opened a new pull request, #4562: [INLONG-4559][Sort] Audit SDK support random routing
doleyzi opened a new pull request, #4562:
URL: https://github.com/apache/incubator-inlong/pull/4562
### [INLONG-4559][Sort] Audit SDK support random routing
- Fixes #4559
### Modifications
- Audit SDK support random routing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4562: [INLONG-4559][Audit] Audit SDK support random routing
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4562:
URL: https://github.com/apache/incubator-inlong/pull/4562#discussion_r893164789
##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/util/Config.java:
##########
@@ -73,37 +72,24 @@ private void initIP() {
}
private void initDockerId() {
- BufferedReader in = null;
try {
Review Comment:
Suggest using the try-with-resource to handle the exception and finally scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4562: [INLONG-4559][Audit] Audit SDK support random routing
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4562:
URL: https://github.com/apache/incubator-inlong/pull/4562#discussion_r893170303
##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderChannel.java:
##########
@@ -17,26 +17,43 @@
package org.apache.inlong.audit.send;
+import io.netty.bootstrap.Bootstrap;
+import io.netty.channel.ChannelFuture;
+import io.netty.channel.ChannelOption;
+import io.netty.channel.EventLoopGroup;
+import io.netty.util.concurrent.DefaultThreadFactory;
+import org.apache.inlong.audit.util.EventLoopUtil;
import org.apache.inlong.audit.util.IpPort;
import io.netty.channel.Channel;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.util.concurrent.Semaphore;
+import java.util.concurrent.ThreadFactory;
public class SenderChannel {
+ private static final Logger logger = LoggerFactory.getLogger(SenderChannel.class);
Review Comment:
Please change the static final variable to the UPPER_CAMEL_CASE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4562: [INLONG-4559][Audit] Support select channels by random routing
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4562:
URL: https://github.com/apache/incubator-inlong/pull/4562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org