You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2017/04/09 04:26:21 UTC
incubator-mynewt-newt git commit: MYNEWT-718 newt - Build failure
under 32-bit OS
Repository: incubator-mynewt-newt
Updated Branches:
refs/heads/master a895dc5cb -> 409f7d307
MYNEWT-718 newt - Build failure under 32-bit OS
Error:
syscfg/syscfg.go:965: constant 4294967295 overflows int
The fix is to remove interrupt priorities entirely. This setting type
was not implemented properly and was unused. Different MCUs have
varying restrictions regarding interrupt priorities (e.g., valid
ranges); this setting type was too general.
Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/409f7d30
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/409f7d30
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/409f7d30
Branch: refs/heads/master
Commit: 409f7d307fb09d22a529891cfb3efd21123e0d57
Parents: a895dc5
Author: Christopher Collins <cc...@apache.org>
Authored: Sat Apr 8 21:15:15 2017 -0700
Committer: Christopher Collins <cc...@apache.org>
Committed: Sat Apr 8 21:15:15 2017 -0700
----------------------------------------------------------------------
newt/syscfg/syscfg.go | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/409f7d30/newt/syscfg/syscfg.go
----------------------------------------------------------------------
diff --git a/newt/syscfg/syscfg.go b/newt/syscfg/syscfg.go
index cac298e..a29f6ce 100644
--- a/newt/syscfg/syscfg.go
+++ b/newt/syscfg/syscfg.go
@@ -58,15 +58,10 @@ const SYSCFG_PRIO_ANY = "any"
// Reserve last 16 priorities for the system (sanity, idle).
const SYSCFG_TASK_PRIO_MAX = 0xef
-// The range of interrupt priorities is hardware dependent, so don't limit
-// these here.
-const SYSCFG_INTERRUPT_PRIO_MAX = 0xffffffff
-
var cfgSettingNameTypeMap = map[string]CfgSettingType{
- "raw": CFG_SETTING_TYPE_RAW,
- "task_priority": CFG_SETTING_TYPE_TASK_PRIO,
- "interrupt_priority": CFG_SETTING_TYPE_INTERRUPT_PRIO,
- "flash_owner": CFG_SETTING_TYPE_FLASH_OWNER,
+ "raw": CFG_SETTING_TYPE_RAW,
+ "task_priority": CFG_SETTING_TYPE_TASK_PRIO,
+ "flash_owner": CFG_SETTING_TYPE_FLASH_OWNER,
}
type CfgPoint struct {
@@ -960,13 +955,6 @@ func EnsureWritten(cfg Cfg, includeDir string) error {
return err
}
- // XXX: Detect these problems at error text generation time.
- if err := calcPriorities(cfg, CFG_SETTING_TYPE_INTERRUPT_PRIO,
- SYSCFG_INTERRUPT_PRIO_MAX, true); err != nil {
-
- return err
- }
-
buf := bytes.Buffer{}
write(cfg, &buf)