You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/14 12:53:29 UTC
[GitHub] [incubator-nuttx-apps] zhhyu7 opened a new pull request #1070: Topic 2
zhhyu7 opened a new pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070
## Summary
feature: wapi add encode parse when scan
fix: iperf can not exit when stop
fix: ap socket can not accept twice
feature: pointer of netdev ioctl support cross-core access via clean dcache
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] zhhyu7 commented on a change in pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
zhhyu7 commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070#discussion_r826547453
##########
File path: wireless/wapi/src/wireless.c
##########
@@ -329,6 +330,7 @@ static int wapi_scan_event(FAR struct iw_event *event,
/* Reset it. */
bzero(temp, sizeof(struct wapi_scan_info_s));
+ temp->encode = 0xffff;
Review comment:
#define IW_ENCODE_ENABLED 0x0000 /* Encoding enabled */
Avoid confusion with existing definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070#discussion_r826530178
##########
File path: wireless/wapi/src/wapi.c
##########
@@ -708,14 +708,14 @@ static int wapi_scan_results_cmd(int sock, int argc, FAR char **argv)
/* Print found aps */
- printf("bssid / frequency / signal level / ssid\n");
+ printf("bssid / frequency / signal level / encode / ssid\n");
for (info = list.head.scan; info; info = info->next)
{
- printf("%02x:%02x:%02x:%02x:%02x:%02x\t%g\t%d\t%s\n",
- info->ap.ether_addr_octet[0], info->ap.ether_addr_octet[1],
- info->ap.ether_addr_octet[2], info->ap.ether_addr_octet[3],
- info->ap.ether_addr_octet[4], info->ap.ether_addr_octet[5],
- info->freq, info->rssi, info->essid);
+ printf("%02x:%02x:%02x:%02x:%02x:%02x\t%g\t%d\t%04x\t%s\n",
+ info->ap.ether_addr_octet[0], info->ap.ether_addr_octet[1],
+ info->ap.ether_addr_octet[2], info->ap.ether_addr_octet[3],
+ info->ap.ether_addr_octet[4], info->ap.ether_addr_octet[5],
+ info->freq, info->rssi, info->encode, info->essid);
Review comment:
why change the alignment? the old code look right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070#discussion_r826267501
##########
File path: wireless/wapi/src/wapi.c
##########
@@ -708,14 +708,18 @@ static int wapi_scan_results_cmd(int sock, int argc, FAR char **argv)
/* Print found aps */
- printf("bssid / frequency / signal level / ssid\n");
- for (info = list.head.scan; info; info = info->next)
+ printf("bssid / frequency / signal level / encode / ssid\n");
+ info = list.head.scan;
+ if (info)
Review comment:
let's remove the unnecessary if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070#discussion_r826530912
##########
File path: wireless/wapi/src/wireless.c
##########
@@ -329,6 +330,7 @@ static int wapi_scan_event(FAR struct iw_event *event,
/* Reset it. */
bzero(temp, sizeof(struct wapi_scan_info_s));
+ temp->encode = 0xffff;
Review comment:
if we have has_encode flag, why need change the default value of enocde to 0xffff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] zhhyu7 commented on a change in pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
zhhyu7 commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070#discussion_r826528208
##########
File path: wireless/wapi/src/wapi.c
##########
@@ -708,14 +708,18 @@ static int wapi_scan_results_cmd(int sock, int argc, FAR char **argv)
/* Print found aps */
- printf("bssid / frequency / signal level / ssid\n");
- for (info = list.head.scan; info; info = info->next)
+ printf("bssid / frequency / signal level / encode / ssid\n");
+ info = list.head.scan;
+ if (info)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1070: fix:iperf/ rpmsg/ wapi issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1070:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org