[GitHub] [thrift] BytedanceRPC commented on pull request #2469: THRIFT-5423: Support go parameter validation in IDL

[GitBox <gi...@apache.org>]

BytedanceRPC commented on pull request #2469:
URL: https://github.com/apache/thrift/pull/2469#issuecomment-946430113


   Thanks for the quick reply.
   
   > > Prefix "vt" stands for validation
   > 
   > That would have not been my first guess. Mmmh. Ok.
   
   Yes, 'vt' stands for validation, considering that 'vt' might make fewer conflicts.
   
   > > defiend_only
   > 
   > The good news is In the code it is spelt correctly :-)
   
   I have fixed the comment.
   
   > > no_sparse       map value must be non-nil pointer
   > 
   > Not sure if I can agree. "Sparse" in the context of memory management means usually something else.
   > 
   > Bonus question: I only skimmed the code so I probably overlooked it, but when and where is it called?
   
   `no_sparse` is designed for go, since like `map<string, StructFoo>` is a pretty common data structure in web service, and a nil value could lead to an unexpected result (an empty struct) after deserilization.  But not sure it's a common problem for all languages, so `no_sparse` is not implemented. I will remove it from the feature matrix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org