You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2015/07/03 10:35:22 UTC
[GitHub] incubator-brooklyn pull request: Use subnet hostname instead of ho...
GitHub user ygy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/732
Use subnet hostname instead of hostname.
Probably resolves problems in local and/or cloud environments.
It seems that ```BrooklynAccessUtils``` is the preferred way to determine Brooklyn's accessible address. Now it uses hostname when used with locations in local or cloud environments. On some occasions it should use subnet_hostname instead of the hostname.
```MongoDBShardedDeploymentIntegrationTest``` demonstrates the scenario.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ygy/incubator-brooklyn fix/mongodb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #732
----
commit e172c7183d042cb5854617ed5e0a0b504af13d57
Author: Yavor Yanchev <ya...@yanchev.com>
Date: 2015-07-03T08:17:47Z
Use subnet hostname instead of hostname. Probably resolves problems
in local and/or cloud environments.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: MongoDB fixes
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/732#issuecomment-119914477
Good fixes, can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: MongoDB fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/732
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use subnet hostname instead of ho...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/732#issuecomment-118329892
After discussion:
The problem is that `addShard` and `--configdb` are supposed to have the same values, matching textually. Can't have hostname at one place, IP at the other. Atm `--configdb` uses `getAttribute(MongoDBConfigServer.SUBNET_HOSTNAME)`, while `addShard` uses the public `MONGO_SERVER_ENDPOINT` initialized with `BrooklynAccessUtils.getBrooklynAccessibleAddress`. The solution would be to use `addShard` with `SUBNET_HOSTNAME` as well. Shouldn't matter for cloud machines (where the values match), but for localhost they are different.
Optional improvements:
* update documentation of `MONGO_SERVER_ENDPOINT` and `HTTP_INTERFACE_URL` to indicate that they are public IPs (better not be used for local connections)
* Implement `HasSubnetHostname` for `LocalhostMachineProvisioningLocation` returning `localhost`, so that `Machines.getSubnetHostname` doesn't return `127.0.0.1` (for consistence).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use subnet hostname instead of ho...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/732#issuecomment-118283018
I'd rather change the address in the `MongoDBShardClusterImpl`.
Also I think the getBrooklynAccessibleAddress is used for defining the public url so changing it to return SUBNET_HOSTNAME would return the opposite - the private hostname
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: MongoDB fixes
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/732#issuecomment-121775091
Thanks @ygy - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---