[GitHub] [airflow] kaxil commented on a change in pull request #9084: Remove TaskInstance.log_filepath attribute

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #9084:
URL: https://github.com/apache/airflow/pull/9084#discussion_r433204306



##########
File path: airflow/models/taskinstance.py
##########
@@ -382,13 +382,6 @@ def generate_command(dag_id: str,
             cmd.extend(["--cfg-path", cfg_path])
         return cmd
 
-    @property
-    def log_filepath(self):
-        iso = self.execution_date.isoformat()
-        log = os.path.expanduser(conf.get('logging', 'BASE_LOG_FOLDER'))
-        return ("{log}/{dag_id}/{task_id}/{iso}.log".format(
-            log=log, dag_id=self.dag_id, task_id=self.task_id, iso=iso))
-

Review comment:
       We should still support it, we can check if we are using a remote_logging or not.
   
   Let's not remove this - I know of many people/companies that are using this property.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org