[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #835: MINIFICPP-1281 - Improve test performance by using event polling instead of sleep by sync

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r463583784



##########
File path: extensions/standard-processors/tests/integration/TailFileTest.cpp
##########
@@ -69,9 +70,11 @@ class TailFileTestHarness : public IntegrationBase {
   }
 
   void runAssertions() override {
-    assert(LogTestController::getInstance().contains("5 flowfiles were received from TailFile input") == true);
-    assert(LogTestController::getInstance().contains("Looking for delimiter 0xA") == true);
-    assert(LogTestController::getInstance().contains("li\\ne5") == true);
+    using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;

Review comment:
       I agree that having this function in our namespace is good, but in this case the `26` function level `using`s make me question whether we should drop a `using` at the top of the file, or go with the practice of having test utils at the top level




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org