[jira] Commented: (GERONIMO-5597) Reenable database-related admin console portlets

["Shenghao Fang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975224#action_12975224 ] 

Shenghao Fang commented on GERONIMO-5597:
-----------------------------------------

Patch details:
\\
\\
1. 

{code:title=plugins/system-database/sysdb-portlets/src/main/java/org/apache/geronimo/console/databasemanager/wizard/DatabasePoolPortlet.java|borderStyle=solid}
// (GeronimoManagedBean) db will cause ClassCastException, use PortletManager.getManagedBean() to get the GeronimoManagedBean.
@@ -781,7 +781,7 @@
             for (JCAManagedConnectionFactory db : databases) {
                 AbstractName dbName = PortletManager.getManagementHelper(renderRequest).getNameFor(db);
                 list.add(new ConnectionPool(moduleName, dbName, (String) dbName.getName().get(NameFactory.J2EE_NAME),
-                        ((GeronimoManagedBean) db).getState()));
+                        PortletManager.getManagedBean(renderRequest, dbName).getState()));
             }
         }
{code} 

2.
{code:title=plugins/system-database/sysdb-portlets/src/main/java/org/apache/geronimo/console/internaldb/DerbyConnectionUtil.java|borderStyle=solid}
// 'Operation not supported' error when invoking $getResource on line 195, please refer to the following code segment
// Use ResourceSource which implements the method $getResource instead of JCAManagedConnectionFactory
// 193             if (SYSTEM_DATASOURCE_NAME!=null && SYSTEM_DB.equalsIgnoreCase(dbName)) {
// 194          	return (DataSource) KernelRegistry.getSingleKernel().invoke(
// 195          			SYSTEM_DATASOURCE_NAME, "$getResource");
@@ -73,7 +73,7 @@
             log.debug("Looking up system datasource name...");
 
             // cache the name for the system data source
-            AbstractNameQuery query = new AbstractNameQuery(JCAManagedConnectionFactory.class.getName());
+            AbstractNameQuery query = new AbstractNameQuery(ResourceSource.class.getName());
             Set<AbstractName> names = KernelRegistry.getSingleKernel().listGBeans(query);
             for (AbstractName name : names) {
                 String nameProperty = name.getNameProperty("name");
{code}

3.
\\
{code:title=plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/web.xml|borderStyle=solid}
// Add <load-on-startup>1</load-on-startup> to each portlet servlet, otherwise the portlet will not be registered to the portal.
@@ -44,6 +44,7 @@
             <param-name>portlet-name</param-name>
             <param-value>InternalDB</param-value>
         </init-param>
+        <load-on-startup>1</load-on-startup>
     </servlet>
{code}

> Reenable database-related admin console portlets
> ------------------------------------------------
>
>                 Key: GERONIMO-5597
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5597
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>            Reporter: Forrest Xia
>            Assignee: Shenghao Fang
>         Attachments: GERONIMO-5597.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.