You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/20 14:52:19 UTC
Review Request 55767: Ensured task's check status is delivered with
reconciliation updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55767/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/protobuf_utils.hpp 6e0201953dfdaef33a6ed4039d3bbbb607e4b379
src/common/protobuf_utils.cpp 0b429267de989f09f76ddc5281890efd8bcb315e
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55767/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55767: Ensured task's check status is delivered
with reconciliation updates.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55767/#review162872
-----------------------------------------------------------
Fix it, then Ship it!
src/common/protobuf_utils.cpp (line 256)
<https://reviews.apache.org/r/55767/#comment234238>
don't think we are putting back ticks around enums.
src/common/protobuf_utils.cpp (line 273)
<https://reviews.apache.org/r/55767/#comment234237>
ditto. backticks.
- Vinod Kone
On Jan. 20, 2017, 2:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55767/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:52 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 6e0201953dfdaef33a6ed4039d3bbbb607e4b379
> src/common/protobuf_utils.cpp 0b429267de989f09f76ddc5281890efd8bcb315e
> src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
>
> Diff: https://reviews.apache.org/r/55767/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55767: Ensured task's check status is delivered
with reconciliation updates.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55767/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 3:38 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/protobuf_utils.hpp faa7e2a759fd2b1ce5def662679f573ec6fefd28
src/common/protobuf_utils.cpp 3ccda1ac2e94ef3fc20d6a2cdb94b6620d914bcd
src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854
Diff: https://reviews.apache.org/r/55767/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov