[GitHub] [accumulo] ctubbsii commented on a change in pull request #1899: Prevent deleted tablets from being flushed

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1899:
URL: https://github.com/apache/accumulo/pull/1899#discussion_r568896442



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -1899,7 +1906,8 @@ public void checkIfMinorCompactionNeededForLogs(List<DfsLogger> closedLogs) {
 
     if (reason != null) {
       // initiate and log outside of tablet lock
-      initiateMinorCompaction(MinorCompactionReason.SYSTEM);
+      TableState tableState = context.getTableManager().getTableState(extent.tableId());
+      initiateMinorCompaction(MinorCompactionReason.SYSTEM, tableState);
       log.debug("Initiating minor compaction for {} because {}", getExtent(), reason);

Review comment:
       It could get confusing that this debug statement says it's initiating a flush and occurs immediately after the one inside `initiateMinorCompaction()` that says not to flush.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org