You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/04/13 04:49:18 UTC
Resolve null pointer issue in DefaultJsUriManager.java (issue869047)
Reviewers: shindig.remailer_gmail.com, johnfargo,
Description:
DefaultJsUriManager should use the uri in the gadget context instead of
the gadget spec, since it can be used without spec defined.
Please review this at http://codereview.appspot.com/869047/show
Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
### Eclipse Workspace Patch 1.0
#P shindig-project
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
(revision 932644)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
(working copy)
@@ -18,19 +18,18 @@
*/
package org.apache.shindig.gadgets.uri;
-import java.util.Collection;
+import com.google.common.collect.Lists;
+import com.google.inject.Inject;
import org.apache.commons.lang.StringUtils;
-import org.apache.shindig.config.ContainerConfig;
import org.apache.shindig.common.uri.Uri;
import org.apache.shindig.common.uri.UriBuilder;
+import org.apache.shindig.config.ContainerConfig;
import org.apache.shindig.gadgets.Gadget;
import org.apache.shindig.gadgets.uri.UriCommon.Param;
-import com.google.common.collect.Lists;
-import com.google.inject.Inject;
-
import java.util.Arrays;
+import java.util.Collection;
/**
* Generates and validates URLs serviced by a gadget JavaScript service
(JsServlet).
@@ -88,7 +87,7 @@
// Finally, version it, but only if !nocache.
if (versioner != null && !gadget.getContext().getIgnoreCache()) {
uri.addQueryParameter(Param.VERSION.getKey(),
- versioner.version(gadget.getSpec().getUrl(), container, extern));
+ versioner.version(gadget.getContext().getUrl(), container,
extern));
}
return uri.toUri();