You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2023/12/20 14:30:54 UTC

[PR] CASSANDRASC-89: Update Google Guice to 7.0.0 [cassandra-sidecar]

smiklosovic opened a new pull request, #86:
URL: https://github.com/apache/cassandra-sidecar/pull/86

   patch by Stefan Miklosovic; reviewed by TBD for CASSANDRASC-89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRASC-89: Update Google Guice to 7.0.0 [cassandra-sidecar]

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #86:
URL: https://github.com/apache/cassandra-sidecar/pull/86#discussion_r2209954927


##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/locator/CachedLocalTokenRanges.java:
##########
@@ -205,7 +205,9 @@ private synchronized Map<Integer, Set<TokenRange>> getCacheOrReload(Metadata met
             if (isClusterTheSame && localTokenRangesCache != null && localTokenRangesCache.containsKey(ks.getName()))
             {
                 // we don't need to rebuild if already cached
-                perKeyspaceBuilder.put(ks.getName(), localTokenRangesCache.get(ks.getName()));
+                Map<Integer, Set<TokenRange>> value = localTokenRangesCache.get(ks.getName());

Review Comment:
   this was failing spotbugs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRASC-89: Update Google Guice to 7.0.0 [cassandra-sidecar]

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #86: CASSANDRASC-89: Update Google Guice to 7.0.0
URL: https://github.com/apache/cassandra-sidecar/pull/86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRASC-89: Update Google Guice to 7.0.0 [cassandra-sidecar]

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #86:
URL: https://github.com/apache/cassandra-sidecar/pull/86#discussion_r2209957617


##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/livemigration/LiveMigrationListInstanceFilesHandler.java:
##########
@@ -20,11 +20,11 @@
 
 import java.io.IOException;
 import java.util.Set;
-import javax.inject.Inject;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.google.inject.Inject;

Review Comment:
   replaced everything by Inject and Singleton from Guice. Guice ones are more prevalent already. After bumping Guice to 7.0.0, javax versions of these annotations were not found anymore. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org