[GitHub] [flink] tillrohrmann commented on a change in pull request #10427: [FLINK-14566] Enable to get/set whether an operator uses managed memory

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #10427: [FLINK-14566] Enable to get/set whether an operator uses managed memory
URL: https://github.com/apache/flink/pull/10427#discussion_r354333320
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
 ##########
 @@ -136,6 +138,14 @@ public static int getNewNodeId() {
 	 */
 	private ResourceSpec preferredResources = ResourceSpec.DEFAULT;
 
+	/**
+	 * This weight indicates how much this transformation relies on managed memory, so that
+	 * transformation highly relies on managed memory would be able to acquire more managed
+	 * memory in runtime (linear association). Note that it only works in cases of UNKNOWN
+	 * resources.
+	 */
+	private int managedMemoryWeight = DEFAULT_MANAGED_MEMORY_WEIGHT;
 
 Review comment:
   I agree with @zhuzhurk that the default value should not be `0`. Otherwise we have a problem if a user writes a stateful `DataStream` program using RocksDB as he cannot set the weight value. And also if he could, then he would need to remember to set it otherwise his operator wouldn't get any managed memory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services