You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 21:32:38 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3242: STORM-3614 switch SystemBolt metrics to V2 API

Ethanlm commented on a change in pull request #3242: STORM-3614 switch SystemBolt metrics to V2 API
URL: https://github.com/apache/storm/pull/3242#discussion_r402608035
 
 

 ##########
 File path: storm-core/test/clj/org/apache/storm/metrics_test.clj
 ##########
 @@ -376,26 +376,5 @@
       (assert-metric-running-sum! "mybolt" "__ack-count/myspout:default" 2 4 cluster)
       (assert-metric-running-sum! "mybolt" "__execute-count/myspout:default" 3 4 cluster))))
 
-(deftest test-system-bolt
 
 Review comment:
   Do we want to add some unit tests in java code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services